Skip to content

Comments

added type hints to xglm pytorch#16500

Merged
Rocketknight1 merged 3 commits intohuggingface:mainfrom
mowafess:add_type_hints_to_xglm_pt
Mar 31, 2022
Merged

added type hints to xglm pytorch#16500
Rocketknight1 merged 3 commits intohuggingface:mainfrom
mowafess:add_type_hints_to_xglm_pt

Conversation

@mowafess
Copy link
Contributor

@mowafess mowafess commented Mar 30, 2022

What does this PR do?

I added type annotations for xglm (PT) as described in [https://github.com//issues/16059]

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1 @patrickvonplaten @sgugger

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 30, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I made a couple of small changes - we've had some issues with symbolic tracing unless we annotate Tuple as Tuple[torch.Tensor], but other than that this looks ready to go.

@Rocketknight1 Rocketknight1 merged commit b808d8a into huggingface:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants