Skip to content

Fix example test and test_fetcher for examples #16478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgugger merged 1 commit into from
Mar 29, 2022
Merged

Fix example test and test_fetcher for examples #16478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/pytorch/text-classification/run_glue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,11 +519,11 @@ def compute_metrics(p: EvalPrediction):

if task == "mnli-mm":
metrics = {k + "_mm": v for k, v in metrics.items()}
if "mnli" in task:
if task is not None and "mnli" in task:
combined.update(metrics)

trainer.log_metrics("eval", metrics)
trainer.save_metrics("eval", combined if "mnli" in task else metrics)
trainer.save_metrics("eval", combined if task is not None and "mnli" in task else metrics)

if training_args.do_predict:
logger.info("*** Predict ***")
Expand Down
4 changes: 2 additions & 2 deletions utils/tests_fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,9 @@ def infer_tests_to_run(output_file, diff_with_last_commit=False, filters=None):
test_files_to_run.append(f)
# Example files are tested separately
elif f.startswith("examples/pytorch"):
test_files_to_run.append("examples/pytorch/test_examples.py")
test_files_to_run.append("examples/pytorch/test_pytorch_examples.py")
elif f.startswith("examples/flax"):
test_files_to_run.append("examples/flax/test_examples.py")
test_files_to_run.append("examples/flax/test_flax_examples.py")
else:
new_tests = module_to_test_file(f)
if new_tests is not None:
Expand Down