Skip to content

Conversation

@gante
Copy link
Contributor

@gante gante commented Mar 18, 2022

What does this PR do?

I missed these 2 in the past refactor PR (#15944). It reverts the error from as mentioned here (#16230) to its previous form, as tracked here (#15983).

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after looking the change of TFBart, TFT5 in #15944). Thank you @gante !

@gante gante changed the title Update use of past to match new generate code TF - update (vision_)encoder_decoder past variable Mar 18, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 18, 2022

The documentation is not available anymore as the PR was closed or merged.

@gante gante merged commit 9fef668 into huggingface:master Mar 21, 2022
@gante gante deleted the fix_past branch March 21, 2022 19:55
@gante gante restored the fix_past branch March 28, 2022 15:58
@gante gante deleted the fix_past branch March 28, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants