bert: properly mention deprecation of TF2 conversion script#16171
Merged
LysandreJik merged 1 commit intohuggingface:mainfrom Apr 7, 2022
stefan-it:bert-tf2-conversion-script-deprecation
Merged
bert: properly mention deprecation of TF2 conversion script#16171LysandreJik merged 1 commit intohuggingface:mainfrom stefan-it:bert-tf2-conversion-script-deprecation
LysandreJik merged 1 commit intohuggingface:mainfrom
stefan-it:bert-tf2-conversion-script-deprecation
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Mar 28, 2022
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Thank you for that, @stefan-it! Do you know if it would be hard to have the script support models trained with TF's BERT >2.3?
Collaborator
Author
|
Hi @LysandreJik , unfortunately, there's no working example code for pre-training in the TF models repo yet (I did some experiments, but I was not able to get a working setup). However, there's a Roformer code (https://github.com/tensorflow/models/tree/master/official/projects/roformer) available and training is working. |
Member
|
Sounds good, let's merge the PR like this then. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
after training some BERT models with the TF2 implementation from the TF models repo, I just made the following observations:
The training code was deprecated a while ago, and now lives under the
legacynamespace. I have trained models with this "legacy" implementation but the TF2 conversion script is no longer working.I did some debugging, trained a few models and found out that the latest working version is v2.3.
For that reason, I have just updated the description in the TF2 conversion script.