Skip to content

Fix TFSequenceSummary's activation #15643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rocketknight1 merged 2 commits into from
Feb 15, 2022
Merged

Fix TFSequenceSummary's activation #15643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4117a0
fix TFSequenceSummary
ydshieh Feb 1, 2022
adeb456
fix
ydshieh Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/transformers/modeling_tf_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
from huggingface_hub import Repository, list_repo_files
from requests import HTTPError

from .activations_tf import get_tf_activation
from .configuration_utils import PretrainedConfig
from .dynamic_module_utils import custom_object_save
from .file_utils import (
Expand Down Expand Up @@ -1957,9 +1958,11 @@ def __init__(self, config: PretrainedConfig, initializer_range: float = 0.02, **
num_classes, kernel_initializer=get_initializer(initializer_range), name="summary"
)

self.has_activation = hasattr(config, "summary_activation") and config.summary_activation == "tanh"
if self.has_activation:
self.activation = tf.keras.activations.tanh
self.has_activation = False
activation_string = getattr(config, "summary_activation", None)
if activation_string is not None:
self.has_activation = True
self.activation = get_tf_activation(activation_string)
Copy link
Collaborator Author

@ydshieh ydshieh Feb 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code could be simplified here: having has_activation, activation_string and activation at the same time seems a bit too much.

Copy link
Member

@Rocketknight1 Rocketknight1 Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay as a quick fix!


self.has_first_dropout = hasattr(config, "summary_first_dropout") and config.summary_first_dropout > 0
if self.has_first_dropout:
Expand Down