Experimenting with adding proper get_config() and from_config() methods #14361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Nov 10, 2021
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
This is a nice, clean fix.
Member
|
It would be ideal to add tests to ensure that the model's serialization works correctly. |
LysandreJik
approved these changes
Nov 11, 2021
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
LGTM, thank you, @Rocketknight1
Contributor
|
Just a small comment from my side - I think I stumbled across the problem that the returned get_config was not fully JSON serializable (as it contained a reference to a tf DType class) - I circumvented this by adding a custom JSONEncoder for it; but it may be worthwhile testing for json.dumps(config) as well? |
Member
Author
|
@Zahlii That's a great idea! Would you be willing to write a test for it, or modify the existing test, and tag me for review? |
Contributor
|
See #14415 |
LysandreJik
pushed a commit
that referenced
this pull request
Nov 16, 2021
…ds (#14361) * Experimenting with adding proper get_config() and from_config() methods * Adding a test for get/from config * Fix test for get/from config
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issues with saving/loading Keras models containing Transformers models as layers, among other problems.