Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reference the types in package json #81

Closed
wants to merge 2 commits into from

Conversation

chelouche9
Copy link
Contributor

No description provided.

@chelouche9
Copy link
Contributor Author

@xenova added the types to the package json file so the types could be used.

package.json Outdated Show resolved Hide resolved
@xenova
Copy link
Collaborator

xenova commented Apr 11, 2023

Is there a way to do this that allows users to use npm link? If I'm not mistaken, this will cause an issue since the types won't be updated?

Also, this main.d.ts file won't be updated each time we build.

@xenova
Copy link
Collaborator

xenova commented Apr 11, 2023

I've also drafted a PR that should do the same. Although, I still don't think npm link will work,

@chelouche9
Copy link
Contributor Author

chelouche9 commented Apr 13, 2023

Also, this main.d.ts file won't be updated each time we build.

That is right, the main.d.ts file is not updated. I will try to find a solution that won't require us to change the build process.

@xenova btw, I see you have created another PR. is it still needed?

@xenova
Copy link
Collaborator

xenova commented May 15, 2023

Changes live on main 👍

@xenova xenova closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants