Skip to content

Conversation

@kungfooman
Copy link
Contributor

@kungfooman kungfooman commented Nov 25, 2023

Fixes: #504

While implementing the runtime type inspector in #409, I come across various type issues that I would like to fix in this standalone PR for easier discussion.

I'm figuring this out on a per-example basis and SpeechT5 is down to 3 errors now:

image

The config.behavior type issue is about a discrepancy between between this type:

https://github.com/xenova/transformers.js/blob/768a2e26d7f34746caa2b102f55dbd270c5d6f36/src/tokenizers.js#L1317-L1319

And this Python JSON generator code:

https://github.com/xenova/transformers.js/blob/768a2e26d7f34746caa2b102f55dbd270c5d6f36/scripts/extra/speecht5.py#L40-L47

Should we use "Isolated" or "isolated"? I don't know which one is "right", the only occurance of "isolated" I can find is here:

https://github.com/huggingface/transformers/blob/35551f9a0f66a22de4971b4a51b3c172d3b87f95/src/transformers/convert_slow_tokenizer.py#L633-L639

@kungfooman kungfooman marked this pull request as draft December 11, 2023 10:46
@kungfooman
Copy link
Contributor Author

kungfooman commented Jan 25, 2024

Also came across this while testing new Depth-Anything PR with RTI:

image

Property size is not marked as error, but RTI also found an error with it (since it can be an object containing width/height properties, not just a singular number that turns into equal width/height).

(fix in next commit)

Updated:

image

@kungfooman kungfooman marked this pull request as ready for review January 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant