Add from_bytes approach for creating tokenizers
#1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HaoboGu <haobogu@outlook.com>
Narsil
approved these changes
Jul 15, 2022
Contributor
Narsil
left a comment
Narsil
left a comment
There was a problem hiding this comment.
LGTM, left a nit (feel free to ignore it if you don't agree).
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
We can consider the tests wokring, this is linked to clippy update. |
Narsil
pushed a commit
that referenced
this pull request
Aug 23, 2022
Signed-off-by: HaoboGu <haobogu@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1013.
Tokenizer can be created from bytes in memory using added
Tokenizers::from_bytes.Signed-off-by: HaoboGu haobogu@outlook.com