Skip to content

feat: update metrics package to support modern rust#850

Merged
alvarobartt merged 1 commit intohuggingface:mainfrom
daeho-ro:main
Mar 31, 2026
Merged

feat: update metrics package to support modern rust#850
alvarobartt merged 1 commit intohuggingface:mainfrom
daeho-ro:main

Conversation

@daeho-ro
Copy link
Copy Markdown
Contributor

What does this PR do?

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines.
  • Did you write any new necessary tests? If applicable, did you include or update the insta snapshots?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@daeho-ro daeho-ro changed the title Main feat: update metrics package to support modern rust Mar 30, 2026
Copy link
Copy Markdown
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daeho-ro, could you please elaborate on what do you mean by "support modern rust"? Since as per https://github.com/metrics-rs/metrics/blob/main/metrics/CHANGELOG.md#0230---2024-05-27 it seems that the MSRV is already 1.70+ and we don't leverage any of the newer features or patches in the more recent versions, so I don't see a strong reason to update from 0.23 to 0.23.1, but I might be wrong so feel free to elaborate further if there's a rationale 👍🏻

@daeho-ro
Copy link
Copy Markdown
Contributor Author

metrics-rs/metrics#564

0.23 doesn't build with rust 1.94, so that is why I open a PR.

Copy link
Copy Markdown
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @daeho-ro, thanks for the clarification! I'll merge to support Rust 1.94 as it's stable, though on Text Embeddings Inference we technically validate support on Rust 1.92 🤗

@alvarobartt alvarobartt merged commit c14ee47 into huggingface:main Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants