feat: update metrics package to support modern rust#850
feat: update metrics package to support modern rust#850alvarobartt merged 1 commit intohuggingface:mainfrom
metrics package to support modern rust#850Conversation
alvarobartt
left a comment
There was a problem hiding this comment.
Hey @daeho-ro, could you please elaborate on what do you mean by "support modern rust"? Since as per https://github.com/metrics-rs/metrics/blob/main/metrics/CHANGELOG.md#0230---2024-05-27 it seems that the MSRV is already 1.70+ and we don't leverage any of the newer features or patches in the more recent versions, so I don't see a strong reason to update from 0.23 to 0.23.1, but I might be wrong so feel free to elaborate further if there's a rationale 👍🏻
|
0.23 doesn't build with rust 1.94, so that is why I open a PR. |
alvarobartt
left a comment
There was a problem hiding this comment.
Awesome @daeho-ro, thanks for the clarification! I'll merge to support Rust 1.94 as it's stable, though on Text Embeddings Inference we technically validate support on Rust 1.92 🤗
What does this PR do?
Before submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.