Use rust-toolchain.toml before rustup on Dockerfile-{cuda,cuda-all}#842
Merged
alvarobartt merged 2 commits intomainfrom Mar 6, 2026
Merged
Use rust-toolchain.toml before rustup on Dockerfile-{cuda,cuda-all}#842alvarobartt merged 2 commits intomainfrom
rust-toolchain.toml before rustup on Dockerfile-{cuda,cuda-all}#842alvarobartt merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a
COPY rust-toolchain.toml rust-toolchain.tomlto theDockerfile-cudaandDockerfile-cuda-allfiles, since as those are not pulling fromlukemathwalker/cargo-chef:latest-rust-1.92-bookwormas the base image;rustupwas installing the latest stable Rust version, which was leading to issues when building earlier versions of Text Embeddings Inference e.g.,Which was failing with the following exception:
rustupwas installing the latest stable Rust (1.86+) because no toolchain was specified, and given that Rust 1.86+ tightened lifetime checking for raw pointer casts (see rust-lang/rust#141402 and metrics-rs/metrics#564), it brokenmetrics-0.23.0which was pinned in theCargo.lockon v1.8.0.By copying
rust-toolchain.tomlbefore anycargoinvocation,rustupautomatically installs and uses the exact Rust version, which fixes the immediate compile failure and prevents any future version drift.Before submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.