fix(backend): replace bare except with Exception in device check#821
Merged
alvarobartt merged 1 commit intohuggingface:mainfrom Mar 11, 2026
Merged
Conversation
Replaces a bare `except:` with `except Exception:` in `is_hpu()`. The previous bare except caught `BaseException`, which includes `SystemExit` and `KeyboardInterrupt`. Since this wraps a `subprocess.run` call, it could prevent a user from interrupting the process if the external `hl-smi` command hangs.
Contributor
Author
|
Hi, just checking in on this, it’s ready for review whenever someone has a moment. Thanks! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces a bare
except:clause withexcept Exception:inbackends/python/server/text_embeddings_server/utils/device.py.The previous implementation caught
BaseException, which includesSystemExitandKeyboardInterrupt. Since this block wraps asubprocess.runcall, a bare except could prevent a user from interrupting the process (Ctrl+C) if the externalhl-smicommand hangs or takes too long.Verification