Skip to content

Update GitHub templates & fix mentions to Text Embeddings Inference #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 11, 2025
Merged

Update GitHub templates & fix mentions to Text Embeddings Inference #697

merged 5 commits into from
Aug 11, 2025

Conversation

@alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Aug 11, 2025

What does this PR do?

This PR updates the following:

  • .github/PULL_REQUEST_TEMPLATE.md to fix formatting, links, and remove Olivier from the "Who can review?" section to prevent overloading his inbox with notifications
  • CONTRIBUTING.md and CODE_OF_CONDUCT.md to fix both formatting and mentions to Text Generation Inference (TGI) instead of Text Embeddings Inference (TEI)
  • Fix wrong mentions to TGI instead of TEI over the codebase

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Narsil

@alvarobartt
Update .github/PULL_REQUEST_TEMPLATE.md
68a9f4a 
- Fix formatting to be single line
- Spelling on Github to GitHub
- Remove Olivier from "Who can review" to prevent overloading his inbox
with notifications
@alvarobartt
Update CONTRIBUTING.md
d941fce 
- text-embeddings-inference to Text Embeddings Inference (TEI) when
applicable
- Fix outdated mentions to TGI to TEI instead
@alvarobartt
Remove leading line-break in CODE_OF_CONDUCT.md
c52b1cd
@alvarobartt
Fix wrong mentions to text-generation-inference instead
50c27a6
@alvarobartt
Run pre-commit run --all-files to fix fmt
7f6b697 
This change is unrelated to the PR but required, as it seems that `fmt`
is broken on `main`
@alvarobartt alvarobartt requested a review from Narsil August 11, 2025 08:22
Narsil
Narsil approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarobartt alvarobartt merged commit ea5fe86 into main Aug 11, 2025
13 of 14 checks passed
@alvarobartt alvarobartt deleted the update-templates-and-mentions branch August 11, 2025 13:12
alvarobartt added a commit that referenced this pull request Sep 4, 2025
@alvarobartt
Update GitHub templates & fix mentions to Text Embeddings Inference (#…
6b415aa 
…697)
@BrewTestBot BrewTestBot mentioned this pull request Sep 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Narsil Narsil Narsil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alvarobartt @Narsil