Bug in DenoisingAutoEncoderLoss.py #2619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaarsen
reviewed
May 1, 2024
| @@ -114,7 +114,7 @@ def __init__(self, model: SentenceTransformer, decoder_name_or_path: str = None, | |||
| ) | |||
| decoder_base_model_prefix = self.decoder.base_model_prefix | |||
| PreTrainedModel._tie_encoder_decoder_weights( | |||
Member
There was a problem hiding this comment.
Hello!
Well spotted; I see this has been introduced in transformers v4.40.0 here. Because I'd rather not increment the minimum transformers all the way to v4.44.0 yet (I imagine that might cause some compatibility problems for people), I propose an alternative solution:
try:
# Compatibility with transformers <4.40.0
PreTrainedModel._tie_encoder_decoder_weights(
model[0].auto_model, self.decoder._modules[decoder_base_model_prefix], self.decoder.base_model_prefix
)
except TypeError:
# Compatibility with transformers >=4.40.0
PreTrainedModel._tie_encoder_decoder_weights(
model[0].auto_model, self.decoder._modules[decoder_base_model_prefix], self.decoder.base_model_prefix, encoder_name_or_path
)
Contributor
Author
There was a problem hiding this comment.
Thanks! @tomaarsen makes sense. It has been updated and now works fine!
Member
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transformers PreTrainedModel._tie_encoder_decoder_weight in DenoisingAutoEncoderLoss requires positional argument base_encoder_name.