[feat] Add revision to load a specific model version#2419
Merged
tomaarsen merged 1 commit intohuggingface:masterfrom Jan 17, 2024
Merged
[feat] Add revision to load a specific model version#2419tomaarsen merged 1 commit intohuggingface:masterfrom
feat] Add revision to load a specific model version#2419tomaarsen merged 1 commit intohuggingface:masterfrom
Conversation
This was referenced Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1645, closes #1373
Hello!
Pull Request overview
Details
This adds the
revisionkeyword argument toSentenceTransformers, and propagates it down to allhuggingface_hubandtransformerfunctions that load from the Hub. The diff is fairly big, but the change is in essence really simple.I also added some tests to show that different revisions can indeed be successfully loaded.
Thanks @plynch-chwy @yoko92 @amine-mf for your comments on #1645 to notify me of this missing feature.