Fix adalora layer init refactor 2960#3070
Merged
BenjaminBossan merged 2 commits intoMar 3, 2026
Merged
Conversation
The layer initialization was refactored in huggingface#2960. This introduced a bug when initializing AdaLoRA with GPTQ layers because some parameters were missing. This bug is now fixed. The same bugfix is contained in huggingface#3047 but is provided here separately to allow merging it more easily.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layer initialization was refactored in #2960. This introduced a bug
when initializing AdaLoRA with GPTQ layers because some parameters were
missing. This bug is now fixed.
The same bugfix is contained in #3047 along with other changes but is
provided here separately to allow reviewing and merging it more easily.