Skip to content

Fix two issues introduced in AutoGPTQ deprecation #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubnemo merged 5 commits into from
Feb 2, 2026
Merged

Fix two issues introduced in AutoGPTQ deprecation #3014

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bdb972
Fix two issues introduced in AutoGPTQ deprecation
Jan 30, 2026
98f828e
Make sure that hf-doc-builder has requests
Jan 30, 2026
8e9b504
Fix docker build test
Jan 30, 2026
6c3ef86
Ignore DeprecationWarning for BPE as well
Jan 30, 2026
575877b
Re-introduce escaping through env vars
Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/test-docker-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ jobs:
- name: Run step if only the files listed above change
if: steps.changed-files.outputs.any_changed == 'true'
id: set-matrix
env:
ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
run: |
echo "matrix=${ALL_CHANGED_FILES}" >> $GITHUB_OUTPUT
echo "matrix=${{ steps.changed-files.outputs.all_changed_files }}" >> $GITHUB_OUTPUT

@sayakpaul sayakpaul Jan 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the previous implement is for security reasons?

@githubnemo githubnemo Jan 30, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was and it is indeed a potential vector since file names are controlled by a potential attacker - even though the output from the changed-files plugin is JSON encoded I wouldn't bet it is shell escaped as well. I've updated with a fix that uses shell escaping through env vars (like before) but fixes the escaping issue.

build_modified_files:
needs: get_changed_files
name: Build Docker images on modified files
Expand Down
5 changes: 4 additions & 1 deletion docker/peft-gpu/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ RUN apt-get update && \
RUN chsh -s /bin/bash
SHELL ["/bin/bash", "-c"]

RUN conda run -n peft pip install --no-cache-dir bitsandbytes optimum gptqmodel
RUN conda run -n peft pip install --no-cache-dir bitsandbytes optimum

# GPTQmodel doesn't find torch without build isolation
RUN conda run -n peft pip install --no-build-isolation gptqmodel

RUN \
# Add eetq for quantization testing; needs to run without build isolation since the setup
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,7 @@ markers = [

filterwarnings = [
"error::DeprecationWarning:transformers",
# in sync with tests/conftest.py regarding BPE deprecation
"ignore:.*BPE.__init__ will not create from files anymore.*:DeprecationWarning:transformers",
"error::FutureWarning:transformers",
]
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
]
extras["docs_specific"] = [
"black", # doc-builder has an implicit dependency on Black, see huggingface/doc-builder#434
"requests", # doc-builder has an implicit dependency on requests (setup.py doesn't mention it, pyproject does)
"hf-doc-builder",
]
extras["dev"] = extras["quality"] + extras["docs_specific"]
Expand Down
6 changes: 0 additions & 6 deletions src/peft/tuners/lora/gptq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,5 @@ def dispatch_gptq(
if isinstance(target_base_layer, BaseQuantLinear):
new_module = GPTQLoraLinear(target, adapter_name, config=config, **kwargs)
target.qweight = target_base_layer.qweight
else:
quant_linear = get_auto_gptq_quant_linear(cfg)

if quant_linear is not None and isinstance(target_base_layer, quant_linear):
new_module = GPTQLoraLinear(target, adapter_name, config=config, **kwargs)
target.qweight = target_base_layer.qweight

return new_module
Loading