FIX: Generation nightly CI failing due to gemma #2580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a month now, nightly CI has failed with dozens of tests causing this error: > RuntimeError: Offset increment outside graph capture encountered unexpectedly. (link: https://github.com/huggingface/peft/actions/runs/14850392078/job/41692748031) It turns out that huggingface#2458, which added a gemma model to the test suite, is most likely the culprit. Since that commit. On nightly CI (with GPU), when transformers generates with gemma, which uses torch.compile, an error can be triggered. For some reason, this has a side effect on other tests that then results in the error quoted above. As is, there is no solution for the gemma issue. To still allow the tests to run and help discover potential issues, this PR skips the corresponding gemma tests, which should allow the other tests to pass again. I could confirm locally that these tests only fail when the gemma tests are run in the same session. Hopefully, this generalizes to the CI environment.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
approved these changes
Jun 11, 2025
Co-authored-by: githubnemo <[email protected]>
efraimdahl
pushed a commit
to efraimdahl/peft
that referenced
this pull request
Jul 12, 2025
For a month now, nightly CI has failed with dozens of tests causing this error: > RuntimeError: Offset increment outside graph capture encountered unexpectedly. (link: https://github.com/huggingface/peft/actions/runs/14850392078/job/41692748031) It turns out that huggingface#2458, which added a gemma model to the test suite, is most likely the culprit. Since that commit, on nightly CI (with GPU), when transformers generates with gemma, which uses torch.compile, an error can be triggered. For some reason, this has a side effect on other tests that then results in the error quoted above. As is, there is no solution for the gemma issue. To still allow the tests to run and help discover potential issues, this PR skips the corresponding gemma tests, which should allow the other tests to pass again. I could confirm locally that these tests only fail when the gemma tests are run in the same session. Hopefully, this generalizes to the CI environment. --------- Co-authored-by: githubnemo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a month now, nightly CI has failed with dozens of tests causing this error:
(link)
It turns out that #2458, which added a gemma model to the test suite, is most likely the culprit. Since that commit, on nightly CI (with GPU), when transformers generates with gemma, which uses
torch.compile, a compile error can be triggered. For some reason, this has a side effect on other tests that also start failing with compile errors such as the one shown above. In isolation these tests pass.As is, there is no solution for the gemma issue. To still allow the tests to run and help discover potential issues, this PR skips the corresponding gemma tests, which should allow the other tests to pass again.
I could confirm locally that these tests only fail when the gemma tests are run in the same session. Hopefully, this generalizes to the CI environment.