Skip to content

Remove deepspeed_reinit #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
regisss merged 3 commits into from
Jun 7, 2022
Merged

Remove deepspeed_reinit #210

regisss merged 3 commits into from
Jun 7, 2022

Conversation

@regisss
Copy link
Contributor

@regisss regisss commented Jun 6, 2022

What does this PR do?

deespeed_reinit has been removed from transformers.deespeed (see this PR). This PR updates ORTTrainer with these changes.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss regisss requested a review from JingyaHuang June 6, 2022 21:17
JingyaHuang
JingyaHuang approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating this @regisss

@regisss regisss merged commit fa77bbc into huggingface:main Jun 7, 2022
@regisss regisss deleted the remove_deepspeed_reinit branch June 7, 2022 11:55
@adriangonz adriangonz mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JingyaHuang JingyaHuang JingyaHuang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@regisss @JingyaHuang