Skip to content

Comments

Apply deprecated evaluation_strategy#1819

Merged
IlyasMoutawwakil merged 1 commit intomainfrom
muellerzr-deprecated-evaluation-strategy
Sep 6, 2024
Merged

Apply deprecated evaluation_strategy#1819
IlyasMoutawwakil merged 1 commit intomainfrom
muellerzr-deprecated-evaluation-strategy

Conversation

@muellerzr
Copy link
Contributor

What does this PR do?

This PR applies the deprecated evaluation_strategy from huggingface/transformers#30190.

TL;DR: evaluation_strategy -> eval_strategy

(Should go live in v4.41.0, but opening now so it's here when ready!)

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@muellerzr muellerzr changed the title Apply deprecation Apply deprecated evaluation_strategy Apr 18, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rohan138
Copy link
Contributor

Rohan138 commented Sep 5, 2024

@muellerzr @IlyasMoutawwakil could we merge this?

It currently breaks the examples with transformers>=4.41 because evaluation_strategy is set to None (https://github.com/huggingface/transformers/blob/main/src/transformers/training_args.py#1375, which errors at https://github.com/huggingface/optimum/blob/main/optimum/onnxruntime/training_args.py#L129 because EvaluationStrategy expects one of ['no', 'steps', 'epoch']

@IlyasMoutawwakil IlyasMoutawwakil merged commit 29f23f1 into main Sep 6, 2024
@IlyasMoutawwakil IlyasMoutawwakil deleted the muellerzr-deprecated-evaluation-strategy branch September 6, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants