Remove SharedDDP as it was deprecated from Transformers.#1443
Merged
JingyaHuang merged 2 commits intohuggingface:mainfrom Oct 12, 2023
Merged
Remove SharedDDP as it was deprecated from Transformers.#1443JingyaHuang merged 2 commits intohuggingface:mainfrom
JingyaHuang merged 2 commits intohuggingface:mainfrom
Conversation
added 2 commits
October 10, 2023 23:43
JingyaHuang
approved these changes
Oct 12, 2023
Contributor
JingyaHuang
left a comment
JingyaHuang
left a comment
There was a problem hiding this comment.
Thanks a lot @AdamLouly for the PR, let's get it merged.
4 tasks
Contributor
Author
|
Thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of SharedDDP was deprecated in Transformers, and because Optimum trainer relies on it, it must be removed from Optimum.
The transformers PR:
huggingface/transformers#25702