Skip to content

Conversation

@regisss
Copy link
Contributor

@regisss regisss commented Jul 5, 2023

What does this PR do?

As per title.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss
Copy link
Contributor Author

regisss commented Jul 5, 2023

Doc build failing, need to find a way to install furiosa-libnux

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 20, 2023

The documentation is not available anymore as the PR was closed or merged.

@regisss regisss marked this pull request as ready for review July 20, 2023 16:57
@mht-sharma
Copy link
Contributor

the reference and how-to-guide sections are also showing FuriosaAI. Any idea?

image

@regisss
Copy link
Contributor Author

regisss commented Jul 21, 2023

the reference and how-to-guide sections are also showing FuriosaAI. Any idea?

image

Yeah there was a bug that I just fixed.
I'm also reverting to "FURIOSA" in the side bar as "FURIOSAAI" looks a bit ugly IMO.

@regisss regisss requested a review from mht-sharma July 21, 2023 08:48
@regisss
Copy link
Contributor Author

regisss commented Jul 21, 2023

@mht-sharma It should be better now. Let me know if it's okay to merge!

Copy link
Contributor

@mht-sharma mht-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @regisss

@regisss regisss merged commit e72901c into main Jul 21, 2023
@regisss regisss deleted the add_furiosa_doc branch July 21, 2023 09:44
baskrahmer pushed a commit to baskrahmer/optimum that referenced this pull request Jul 22, 2023
* Add documentation for Optimum Furiosa

* Add furiosa-libnux installation

* Update main doc build

* Refinement

* Refinements

* Revert section rename

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants