Skip to content

Remove deprecated AOT_HPU_TRAINING_BACKEND (#138)#877

Merged
regisss merged 1 commit into
huggingface:mainfrom
HabanaAI:remove_aot_backend
Apr 11, 2024
Merged

Remove deprecated AOT_HPU_TRAINING_BACKEND (#138)#877
regisss merged 1 commit into
huggingface:mainfrom
HabanaAI:remove_aot_backend

Conversation

@astachowiczhabana
Copy link
Copy Markdown
Collaborator

The new backend has been introduced to pytorch-integraton - HPU_BACKEND . The deprecated backend ( AOT_HPU_TRAINING_BACKEND ) shall no longer be available in optimum habana as it's going to be removed from pytorch-integration.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss regisss changed the base branch from v1.11-release to main April 9, 2024 17:12
Comment thread optimum/habana/version.py
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this change?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears because I change the target of the PR from v1.11-release to main. Merging main into the PR branch will make it disappear.

Comment thread setup.py Outdated
QUALITY_REQUIRES = [
"ruff",
"hf_doc_builder @ git+https://github.com/huggingface/doc-builder.git",
"hf_doc_builder",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this change?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Copy Markdown
Collaborator

@libinta libinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astachowiczhabana can you rebase to main

@astachowiczhabana
Copy link
Copy Markdown
Collaborator Author

@libinta @regisss, it's rebased on main

@regisss regisss added the run-test Run CI for PRs from external contributors label Apr 11, 2024
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-test Run CI for PRs from external contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants