Add mark_step for llama inference#875
Merged
Merged
Conversation
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
Signed-off-by: Puneesh Khanna <pkhanna@habana.ai>
libinta
requested review from
bhargaveede,
mandy-li,
ssarkar2 and
vivekgoe
as code owners
kalyanjk
approved these changes
Apr 9, 2024
regisss
approved these changes
Apr 9, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
added a commit
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Puneesh Khanna <pkhanna@habana.ai> Co-authored-by: regisss <15324346+regisss@users.noreply.github.com> Co-authored-by: Sayantan Sarkar <supersarkar@gmail.com> Co-authored-by: Puneesh Khanna <pkhanna@habana.ai> Co-authored-by: Witold Szczurek <152967125+wszczurekhabana@users.noreply.github.com>
Contributor
|
@libinta how much memory can be saved with this PR? is there any perf data that I can refer? |
skaulintel
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Apr 11, 2024
skaulintel
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Apr 12, 2024
* port llama related changes/optimizations to mistral if applicable. * add mark step as in huggingface#875
skaulintel
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Apr 12, 2024
* port llama related changes/optimizations to mistral if applicable. * add mark step as in huggingface#875 * add fusedrope optimization for mistral * add fused rope condition back in
dsmertin
pushed a commit
to dsmertin/optimum-habana
that referenced
this pull request
Apr 17, 2024
Signed-off-by: Puneesh Khanna <pkhanna@habana.ai> Co-authored-by: regisss <15324346+regisss@users.noreply.github.com> Co-authored-by: Sayantan Sarkar <supersarkar@gmail.com> Co-authored-by: Puneesh Khanna <pkhanna@habana.ai> Co-authored-by: Witold Szczurek <152967125+wszczurekhabana@users.noreply.github.com>
This was referenced Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For better memory optimization, add extra mark_step for llama inference.
Fixes # (issue)
Before submitting