Skip to content

Fix graph breaks in torch compile mode#806

Merged
regisss merged 4 commits into
huggingface:mainfrom
HabanaAI:llama_graph_break
Mar 16, 2024
Merged

Fix graph breaks in torch compile mode#806
regisss merged 4 commits into
huggingface:mainfrom
HabanaAI:llama_graph_break

Conversation

@hlahkar
Copy link
Copy Markdown
Contributor

@hlahkar hlahkar commented Mar 15, 2024

What does this PR do?

  1. Fixes Graph Breaks in torch compile mode
  2. Fixes comments in Expose Llama Fused OPs control from run_lora_clm.py #751

scsudhak-intel and others added 2 commits March 15, 2024 05:45
Signed-off-by: Sanju C Sudhakaran <scsudhakaran@habana.ai>
@hlahkar hlahkar requested a review from a user March 15, 2024 05:31
@hlahkar hlahkar requested a review from regisss as a code owner March 15, 2024 05:31
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you just run make style too so that the code style check passes please?

@vivekgoe vivekgoe added the run-test Run CI for PRs from external contributors label Mar 16, 2024
@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Mar 16, 2024

Seems the code style check still fails.
@hlahkar Can you run

pip install -U ruff
make style

and see if some files are changed?

@regisss regisss added run-test Run CI for PRs from external contributors and removed run-test Run CI for PRs from external contributors labels Mar 16, 2024
@regisss regisss merged commit e29aacc into huggingface:main Mar 16, 2024
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Nov 6, 2025
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-test Run CI for PRs from external contributors synapse 1.15

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants