Replacing obsolete API for mediapipe#796
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
libinta
approved these changes
Mar 13, 2024
regisss
added
run-test
regisss
approved these changes
Mar 14, 2024
Collaborator
There was a problem hiding this comment.
LGTM!
@MohitIntel Not an issue with your PR as it also occurs on main, but have you also observed long compilation times in the first training iteration with BridgeTower? Or maybe you tested with CLIP?
With fast_ddp it runs well so no issue here.
This was referenced Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces backend mediapipe API with newer one.
Tested for backward compatibility with synapse 1.14.