Skip to content

Fixing tests by making static_shapes False#778

Merged
vivekgoe merged 1 commit into
huggingface:mainfrom
HabanaAI:beede/fix_tests_static
Mar 10, 2024
Merged

Fixing tests by making static_shapes False#778
vivekgoe merged 1 commit into
huggingface:mainfrom
HabanaAI:beede/fix_tests_static

Conversation

@bhargaveede
Copy link
Copy Markdown

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@bhargaveede bhargaveede added the run-test Run CI for PRs from external contributors label Mar 8, 2024
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@vivekgoe vivekgoe merged commit 639c21b into huggingface:main Mar 10, 2024
puneeshkhanna pushed a commit to puneeshkhanna/optimum-habana-fork that referenced this pull request Mar 11, 2024
HolyFalafel pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Mar 11, 2024
@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Mar 13, 2024

@bhargaveede @vivekgoe Can you just explain quickly why a piece of code was removed in generation/utils.py please? That way it will be documented somewhere if someone wants to understand this change in the future.

@bhargaveede
Copy link
Copy Markdown
Author

@regisss
This code is added for enabling static_shapes in T5.
get_extended_attention_mask (https://github.com/huggingface/optimum-habana/blob/main/optimum/habana/transformers/models/t5/modeling_t5.py#L368) is fulfilling the need. This is redundant and we don't need this now

@bhargaveede bhargaveede deleted the beede/fix_tests_static branch May 16, 2024 06:27
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Nov 6, 2025
…face#778)

Signed-off-by: Urszula <urszula.golowicz@intel.com>
Co-authored-by: Urszula Golowicz <urszula.golowicz@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-test Run CI for PRs from external contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants