Skip to content

Rename whitelist & blacklist #71#765

Merged
regisss merged 3 commits into
huggingface:synapse_1.15from
HabanaAI:dev/dsemiat/allow_block_pre_1.10.0
Mar 22, 2024
Merged

Rename whitelist & blacklist #71#765
regisss merged 3 commits into
huggingface:synapse_1.15from
HabanaAI:dev/dsemiat/allow_block_pre_1.10.0

Conversation

@HolyFalafel
Copy link
Copy Markdown
Contributor

Rename whitelist and blacklist to allowlist and blocklist

@HolyFalafel HolyFalafel requested a review from regisss as a code owner March 5, 2024 14:10
Comment thread tests/transformers/tests/test_modeling_common.py Outdated
Comment thread tests/transformers/tests/test_modeling_common.py Outdated
@libinta libinta added run-test Run CI for PRs from external contributors synapse 1.15 labels Mar 6, 2024
@regisss regisss added run-test Run CI for PRs from external contributors and removed run-test Run CI for PRs from external contributors labels Mar 11, 2024
Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Is it compatible with Synapse v1.14 or should we wait for the release of v1.15 to merge it?

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@HolyFalafel
Copy link
Copy Markdown
Contributor Author

LGTM!

Is it compatible with Synapse v1.14 or should we wait for the release of v1.15 to merge it?

This is relevant to a change in v1.15, so it's incompatible for v1.14

@regisss regisss changed the base branch from main to synapse_1.15 March 22, 2024 21:50
@regisss regisss merged commit a3677d5 into huggingface:synapse_1.15 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-test Run CI for PRs from external contributors synapse 1.15

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants