Skip to content

Add Llama/Llama2 support in Question-Answering#745

Merged
regisss merged 3 commits into
huggingface:mainfrom
kplau1128:support_llama_qa
Mar 18, 2024
Merged

Add Llama/Llama2 support in Question-Answering#745
regisss merged 3 commits into
huggingface:mainfrom
kplau1128:support_llama_qa

Conversation

@kplau1128
Copy link
Copy Markdown
Contributor

@kplau1128 kplau1128 commented Feb 29, 2024

Added Llama/Llama2 support in Question-Answering

@kplau1128 kplau1128 requested a review from regisss as a code owner February 29, 2024 03:37
@kplau1128
Copy link
Copy Markdown
Contributor Author

kplau1128 commented Feb 29, 2024 •
edited
Loading

Fixed issue reported GS-23: missing LlamaForQuestionAnswering class issue reported is fixed by applying huggingface/transformers 28777.

Fixed run_qa.py script to support Llama tokenizer.

@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Feb 29, 2024

LlamaForQuestionAnswering was added in Transformers v4.38, which will be supported by Optimum Habana in a few weeks. Let's wait for that before continuing this PR.

@kplau1128
Copy link
Copy Markdown
Contributor Author

kplau1128 commented Mar 13, 2024

Verified with updated transformer v4.38.2 #788, work fine.

regisss
regisss reviewed Mar 16, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the main branch of your fork and rebase this PR on it please?

Comment thread examples/question-answering/run_qa.py Outdated
@kplau1128
Copy link
Copy Markdown
Contributor Author

kplau1128 commented Mar 18, 2024

rebased

@regisss regisss added the run-test Run CI for PRs from external contributors label Mar 18, 2024
regisss
regisss approved these changes Mar 18, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I pushed two additional commits to refine a bit the README and run make style.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Mar 18, 2024

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss regisss merged commit 7d58f00 into huggingface:main Mar 18, 2024
@astachowiczhabana astachowiczhabana mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@regisss regisss regisss approved these changes

Assignees

No one assigned

Labels

run-test Run CI for PRs from external contributors synapse 1.15

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kplau1128 @regisss @HuggingFaceDocBuilderDev