Skip to content

Update transformer model test script to match with 4.37.1#694

Merged
regisss merged 1 commit into
transformers_4.35from
bert_ci_fix
Feb 8, 2024
Merged

Update transformer model test script to match with 4.37.1#694
regisss merged 1 commit into
transformers_4.35from
bert_ci_fix

Conversation

@yeonsily
Copy link
Copy Markdown
Collaborator

@yeonsily yeonsily commented Feb 7, 2024

Fixed two issues from tests.models.bert.test_modeling_bert.BertModelTest

  1. test_model_weights_reload_no_missing_tied_weights
    The script is updated same as https://github.com/huggingface/transformers/blob/v4.37.2/tests/test_modeling_common.py#L1912

  2. test_save_load_fast_init_to_base
    Change 'model.config.save_pretrained(tmpdirname)' to 'model.save_pretrained(tmpdirname)'
    Referred from UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 64: invalid start byte  transformers#9517

@yeonsily yeonsily requested review from libinta and ssarkar2 February 7, 2024 19:57
@yeonsily yeonsily requested a review from regisss as a code owner February 7, 2024 19:57
Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisss regisss merged commit 5850b96 into transformers_4.35 Feb 8, 2024
@regisss regisss deleted the bert_ci_fix branch February 8, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants