add support for TinyLlama model#693
Conversation
|
@mandy-li Do you know if this commit will be part of Habana DeepSpeed 1.15? |
@regisss , @tjs-intel , DS changes should be submitted to internal habana deepspeed-fork repo |
deepspeedai/DeepSpeed@c8c57b8 is part of the v0.13 release of DeepSpeed. I guess it should be part of Habana DeepSpeed 1.15 or 1.16 no? |
Yes, will be in 1.15, but we modified it in the internal Habana DS repo. |
|
OH-fork PR here HabanaAI#25 |
620fd07 to
595cb67
Compare
595cb67 to
e3f8822
Compare
|
HabanaAI#25 has been merged |
So we need to wait for 1.15 to be merged to merge this PR right? |
|
@regisss I will leave that discussion to the maintainers. The consequence of merging this before the HabanaAI/DeepSpeed 1.15 release is that the latest released version of HabanaAI/DeepSpeed (1.14) does not support safetensors. If there are any models with both |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
left a comment
There was a problem hiding this comment.
Thanks for the clear explanation @tjs-intel! In that case, we'll wait for the release of SynapseAI v1.15 to merge this PR.
Changes look good to me, could you also run the following to make the code style check pass please?
pip install -U ruff
make style
|
Merging in the |
What does this PR do?
The TinyLlama model only has checkpoints in the form of
model.safetensors. This checkpoint needs to be included in the list of checkpoints that is passed to DeepSpeed in order for the model to function properly when initialized with DeepSpeed.This PR adds the safetensor checkpoints to the list of checkpoints passed to DeepSpeed.
Note: This change requires an upstream commit in microsoft/DeepSpeed to be merged downstream to HabanaAI/DeepSpeed in order for DeepSpeed to support the provided safetensor format.
Before submitting