Fix version check when console output is disabled#688
Merged
Conversation
Contributor
Author
|
@regisss , I went with a different approach than what we discussed so we don't have to skip the check. This should capture the case if version is not set: https://github.com/huggingface/optimum-habana/blob/main/optimum/habana/utils.py#L201 . Let me know what you think. |
Collaborator
|
@vidyasiv Can you also run the following from the root of the repo please? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
Apologies, I ran it and updated code. |
regisss
pushed a commit
that referenced
this pull request
Feb 12, 2024
jychen21
pushed a commit
to jychen21/optimum-habana
that referenced
this pull request
Feb 27, 2024
dudilester
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Feb 28, 2024
HolyFalafel
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #684
Before submitting