Skip to content

add DPO and SFT of TRL support in Gaudi and example#601

Merged
libinta merged 2 commits into
mainfrom
trl_dpo
Dec 25, 2023
Merged

add DPO and SFT of TRL support in Gaudi and example#601
libinta merged 2 commits into
mainfrom
trl_dpo

Conversation

@sywangyi
Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@sywangyi sywangyi requested a review from regisss as a code owner December 15, 2023 06:09
@sywangyi
Copy link
Copy Markdown
Collaborator Author

should work with #600

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sywangyi
Copy link
Copy Markdown
Collaborator Author

@regisss do we have plan to enable TRL in Gaudi? I have enabled PPO, DPO and SFT by my side. If we have the plan. I will upload the PR one by one.

@sywangyi
Copy link
Copy Markdown
Collaborator Author

add @libinta for comment

Comment thread examples/trl_example/stack_llama_2/README.md Outdated
Comment thread examples/trl_example/stack_llama_2/README.md Outdated
Comment thread examples/trl_example/stack_llama_2/README.md Outdated
Comment thread examples/trl_example/stack_llama_2/README.md Outdated
Comment thread examples/trl_example/stack_llama_2/README.md Outdated
Comment thread examples/trl_example/stack_llama_2/dpo_llama2.py Outdated
@sywangyi sywangyi force-pushed the trl_dpo branch 2 times, most recently from 6a016a3 to a2d0927 Compare December 20, 2023 10:54
Copy link
Copy Markdown
Collaborator

@libinta libinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a link in each .py file to specify where this file is ported from and the version also?

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Copy Markdown
Collaborator Author

sywangyi commented Dec 25, 2023

can you add a link in each .py file to specify where this file is ported from and the version also?

done,also upgrade the trl to the latest tag, v0.7.6

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@libinta libinta merged commit 79f6de3 into main Dec 25, 2023
@regisss regisss deleted the trl_dpo branch January 3, 2024 18:11
dsocek pushed a commit to dsocek/optimum-habana that referenced this pull request Jan 4, 2024
* add DPO and SFT of TRL support in Gaudi and example

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>

* upgrade SFTTrainer/DPO trainer and stack_llama_2 example to v0.7.6

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>

---------

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants