Skip to content

Update the repo with changes brought by Transformers 4.19.1#50

Merged
regisss merged 2 commits into
mainfrom
transformers_4.19.1
May 24, 2022
Merged

Update the repo with changes brought by Transformers 4.19.1#50
regisss merged 2 commits into
mainfrom
transformers_4.19.1

Conversation

@regisss
Copy link
Copy Markdown
Collaborator

@regisss regisss commented May 16, 2022

What does this PR do?

Make the repo up to date with Transformers 4.19.1.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss regisss requested a review from libinta May 16, 2022 18:58
Copy link
Copy Markdown
Collaborator

@libinta libinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regis, what's the test result? can we have sth like shared document to track test result for each release?

@regisss
Copy link
Copy Markdown
Collaborator Author

regisss commented May 16, 2022

Regis, what's the test result? can we have sth like shared document to track test result for each release?

I'm going to launch the regression tests manually on this branch to be sure that we keep the same performance. You'll be able to see if these tests have passed here (in the "Actions" tab).

@regisss
Copy link
Copy Markdown
Collaborator Author

regisss commented May 17, 2022

@libinta You can see here that all the regression tests passed.

Copy link
Copy Markdown
Collaborator

@libinta libinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regisss is albert xxl running over saturday? what's the result?

@regisss
Copy link
Copy Markdown
Collaborator Author

regisss commented May 24, 2022

@regisss is albert xxl running over saturday? what's the result?

The CI run of Saturday skipped all regression tests since examples are not up to date in the main branch (checking if examples are up to date is the first test and if it fails all the following tests are skipped). But I ran it manually and it gave me the exact same results as before. Actually you can check it in the log files I sent you on Slack.

@regisss regisss merged commit e6adab9 into main May 24, 2022
@regisss regisss deleted the transformers_4.19.1 branch May 24, 2022 07:37
schoi-habana pushed a commit that referenced this pull request Mar 8, 2024
Add disk_offload flag that controls device_map=auto. Setting this flag enbales weights
offload to disk when cpu memory runs OOM.
Add const serialization path flag that gets a path for where to serialize const sections,
so if there is no space on device to save all const sections they will be offloaded to disk.
regisss pushed a commit that referenced this pull request Mar 22, 2024
Co-authored-by: Yan Tomsinsky <73292515+Yantom1@users.noreply.github.com>
libinta added a commit that referenced this pull request Mar 23, 2024
Add disk_offload flag that controls device_map=auto. Setting this flag enbales weights
offload to disk when cpu memory runs OOM.
Add const serialization path flag that gets a path for where to serialize const sections,
so if there is no space on device to save all const sections they will be offloaded to disk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants