Skip to content

Fix run_clm.py for streaming datasets #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regisss merged 1 commit into from
Oct 17, 2025
Merged

Fix run_clm.py for streaming datasets #2309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/language-modeling/run_clm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ def compute_metrics(eval_preds):
metrics = trainer.evaluate()

if data_args.streaming:
metrics["eval_samples"] = max_eval_samples
metrics["eval_samples"] = training_args.max_steps * training_args.per_device_eval_batch_size
else:
max_eval_samples = (
data_args.max_eval_samples if data_args.max_eval_samples is not None else len(eval_dataset)
Expand Down
Loading