Skip to content

[mllama] Minor fixes after transformers upgrade#2272

Merged
regisss merged 1 commit into
huggingface:mainfrom
ugolowic:mllama-fixes-main
Sep 22, 2025
Merged

[mllama] Minor fixes after transformers upgrade#2272
regisss merged 1 commit into
huggingface:mainfrom
ugolowic:mllama-fixes-main

Conversation

@ugolowic
Copy link
Copy Markdown
Collaborator

These are fixes for functional errors which cropped up after transformers upgrade.

To reproduce:

PT_HPU_LAZY_MODE=1  python3  $OPTIMUM_HABANA/examples/image-to-text/run_pipeline.py    --model_name_or_path meta-llama/Llama-3.2-11B-Vision-Instruct   --use_hpu_graphs --limit_hpu_graphs --use_kv_cache --max_new_tokens 2048 --bf16 --batch_size 16  --use_flash_attention --flash_attention_recompute    --sdp_on_bf16 --logits_bf16 --trim_logits --max_input_tokens 2048    --ignore_eos

The example above requires also https://github.com/huggingface/optimum-habana/pull/2266/files to be applied.

Signed-off-by: Urszula <urszula.golowicz@intel.com>
@ugolowic ugolowic requested a review from regisss as a code owner September 19, 2025 10:33
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Sep 19, 2025

This is the same as #2267 right? Except this one targets the main branch and the other one the 1.20 release branch?

@ugolowic
Copy link
Copy Markdown
Collaborator Author

@regiss, yes, I closed that one. Please cherry-pick this change also to v1.20-release

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit bfdd2b8 into huggingface:main Sep 22, 2025
2 of 5 checks passed
regisss pushed a commit that referenced this pull request Sep 22, 2025
Signed-off-by: Urszula <urszula.golowicz@intel.com>
@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Sep 22, 2025

Please cherry-pick this change also to v1.20-release

Done!

astachowiczhabana pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Sep 30, 2025
Signed-off-by: Urszula <urszula.golowicz@intel.com>
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
…uggingface#704)

Signed-off-by: Urszula <urszula.golowicz@intel.com>
Co-authored-by: Urszula Golowicz <urszula.golowicz@intel.com>
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Nov 6, 2025
…uggingface#704)

Signed-off-by: Urszula <urszula.golowicz@intel.com>
Co-authored-by: Urszula Golowicz <urszula.golowicz@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants