Revert prepare_model to keep FSDP upcast disablement#2270
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
3 tasks
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 22, 2025
Collaborator
|
LGTM |
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
… (huggingface#702) Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com>
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Nov 6, 2025
… (huggingface#702) Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
starting from transformers 4.43 and accelerate 0.33, upcasting was added for FSDP in mixed precision huggingface/accelerate#2674 making FSDP training more stable by upcasting the model if it is both in half precision and uses mixed precision training, but was kept disabled in optimum-habana temporarily due to torch.compile failure cases.
Before submitting