Skip to content

Fix HabanaProfile unit tests to align with idempotent start behavior #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astachowiczhabana merged 1 commit into from
Sep 15, 2025
Merged

Fix HabanaProfile unit tests to align with idempotent start behavior #2258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/test_habana_profiler_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import os
import shutil
import weakref
from unittest.mock import MagicMock

import pytest
Expand Down Expand Up @@ -44,7 +45,7 @@ def patched_profiler(monkeypatch):
@pytest.fixture(autouse=True)
def cleanup():
shutil.rmtree(PROFILER_OUTPUT_DIR, ignore_errors=True)
HabanaProfile._profilers = []
HabanaProfile._profilers = weakref.WeakSet()


def run_profiling(profiler):
Expand Down Expand Up @@ -118,8 +119,9 @@ def test_two_profilers_can_run_sequentially():
assert len(os.listdir(PROFILER_OUTPUT_DIR)) == 2


def test_cannot_start_profiler_when_another_is_running(patched_profiler):
def test_starting_new_profiler_stops_previous(patched_profiler):
another_profiler = HabanaProfile(warmup=1, active=1)
patched_profiler.start()
with pytest.raises(RuntimeError):
another_profiler.start()
another_profiler.start()
assert not patched_profiler._running
assert another_profiler._running