fea(): WA for run_clm config imports#2232
Merged
Merged
Conversation
Contributor
Author
imangohari1
referenced
this pull request
in imangohari1/optimum-habana
Aug 27, 2025
… for run_clm. fea(gemma2/3): remoevd the configuration changes and simplied the swa implementation
Collaborator
|
I think the current change is fine |
Contributor
Author
@regisss thanks. I made this PR ready then. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
astachowiczhabana
pushed a commit
that referenced
this pull request
Aug 29, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 2, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 17, 2025
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is bug in
run_clm.pythat instead of loading the local OH configuration, it is loading the upstream HF here:This is WA to fix it.
Reproducer
Applying this patch
and run cmd
make test_instals; python3 examples/language-modeling/run_clm.py --model_name_or_path mistralai/Mistral-7B-v0.1 --gaudi_config_name Habana/gpt2 --dataset_name wikitext --do_train --output_dir /tmp/tmp3vtnetji --overwrite_output_dir --learning_rate 0.0002 --per_device_train_batch_size 4 --per_device_eval_batch_size 4 --num_train_epochs 2 --use_habana --throughput_warmup_steps 3 --save_strategy no --use_lazy_mode --do_eval --dataset_config_name wikitext-2-raw-v1 --use_hpu_graphs_for_inferenceResults
Notes:
modeling_XX.pyfiles.--
co-authored by Yaser Afshar @yafshar
Before submitting