Skip to content

Make mbxp_evaluation setup script non-interactive#2225

Merged
regisss merged 1 commit into
huggingface:mainfrom
HabanaAI:dev/pbielak/mbxp-eval-setup
Aug 25, 2025
Merged

Make mbxp_evaluation setup script non-interactive#2225
regisss merged 1 commit into
huggingface:mainfrom
HabanaAI:dev/pbielak/mbxp-eval-setup

Conversation

@pbielak
Copy link
Copy Markdown
Collaborator

@pbielak pbielak commented Aug 25, 2025

What does this PR do?

The mbxp_evaluation/evaluation_setup/ubuntu.sh script contains commands that require user input (confirmation of installation etc.), which makes the script not suitable for automated tests. This commit fixes these commands (adding -y arguments).

The `mbxp_evaluation/evaluation_setup/ubuntu.sh` script contains
commands that require user input (confirmation of installation etc.),
which makes the script not suitable for automated tests. This commit
fixes these commands (adding `-y` arguments).
@pbielak pbielak requested a review from regisss as a code owner August 25, 2025 08:28
Copy link
Copy Markdown
Collaborator

@AKloniecki AKloniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit 50d0c73 into huggingface:main Aug 25, 2025
2 of 4 checks passed
@pbielak pbielak deleted the dev/pbielak/mbxp-eval-setup branch August 25, 2025 08:41
imangohari1 pushed a commit to imangohari1/optimum-habana that referenced this pull request Aug 28, 2025
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
…uggingface#631)

Co-authored-by: Piotr Bielak <pbielak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants