Respect --dataset_max_samples when using --mlcommons_dataset#2223
Merged
regisss merged 1 commit intoAug 24, 2025
Merged
Conversation
The current implementation of `run_generation.py` does not take into account the value of `--dataset_max_samples` when using an MLCommons dataset (via the `--mlcommons_dataset` argument). Limiting the number of dataset samples allows for faster debugging.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
imangohari1
pushed a commit
to imangohari1/optimum-habana
that referenced
this pull request
Aug 28, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Aug 29, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 2, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 17, 2025
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
…gingface#2223) (huggingface#630) Co-authored-by: Piotr Bielak <pbielak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current implementation of
run_generation.pydoes not take into account the value of--dataset_max_sampleswhen using an MLCommons dataset (via the--mlcommons_datasetargument). Limiting the number of dataset samples allows for faster debugging.