Skip to content

fea(pytests): Added gemma/gemma2 HF pytests#2213

Merged
regisss merged 2 commits into
huggingface:mainfrom
imangohari1:ig/gemma-pytests
Sep 9, 2025
Merged

fea(pytests): Added gemma/gemma2 HF pytests#2213
regisss merged 2 commits into
huggingface:mainfrom
imangohari1:ig/gemma-pytests

Conversation

@imangohari1
Copy link
Copy Markdown
Contributor

What does this PR do?

Added the HF upstream pytests for gemma and gemma2.

Tests

PT_HPU_LAZY_MODE=1 RUN_SLOW=true python -m pytest --device gaudi2 tests/transformers/tests/models/gemma2/ -s -v
========================================================== 113 passed, 74 skipped, 13 warnings in 15.52s ===========================================================
PT_HPU_LAZY_MODE=1 RUN_SLOW=true python -m pytest --device gaudi2 tests/transformers/tests/models/gemma/ -s -v
=========================================================== 58 passed, 39 skipped, 9 warnings in 10.32s ============================================================

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@imangohari1 imangohari1 requested a review from regisss as a code owner August 19, 2025 23:36
@imangohari1
Copy link
Copy Markdown
Contributor Author

@regisss @astachowiczhabana FYI on this.

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just left a nit.
Since these tests are not part of HF's CI, waiting for @astachowiczhabana's approval before merging.

Comment thread tests/transformers/tests/models/gemma2/test_modeling_gemma2.py Outdated
@imangohari1 imangohari1 requested a review from regisss August 21, 2025 19:27
@imangohari1
Copy link
Copy Markdown
Contributor Author

LGTM, I just left a nit. Since these tests are not part of HF's CI, waiting for @astachowiczhabana's approval before merging.

of course @regisss. I addressed your comment.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@imangohari1 imangohari1 mentioned this pull request Aug 28, 2025
3 tasks
@imangohari1
Copy link
Copy Markdown
Contributor Author

@astachowiczhabana CC @regisss
Hi adam,
can we review this and merge it? it is working all fine now. WDYT?

@karol-brejna-i karol-brejna-i self-assigned this Sep 4, 2025
@astachowiczhabana astachowiczhabana self-requested a review September 5, 2025 09:24
@astachowiczhabana
Copy link
Copy Markdown
Collaborator

LGTM too,
"Next Synapse Release Validation" is now failing on unrelated matters

@astachowiczhabana
Copy link
Copy Markdown
Collaborator

@regisss can we merge this?

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit 29a3b25 into huggingface:main Sep 9, 2025
2 of 5 checks passed
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
…ngface#669)

Co-authored-by: Iman Gohari <s.m.iman.gohari@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants