Updating FusedAdamW epsilon to Habana default 1e-6#22
Merged
Conversation
regisss
requested changes
Apr 11, 2022
Collaborator
regisss
left a comment
regisss
left a comment
There was a problem hiding this comment.
I propose a small change so that only the default value is modified.
Also, not related to optimum-habana, would it be possible to update the documentation of Gaudi so that it is explicitly mentioned that the default value of epsilon is not the same one as for torch.optim.AdamW? Because here the doc says to refer to torch.optim.AdamW, which is misleading since there the default value of espilon is 1e-8.
MohitIntel
force-pushed
the
fix_default_fusedadamW_params
branch
from
9f13b92 to
81c6b3a
Compare
regisss
approved these changes
Apr 11, 2022
Collaborator
|
@regisss we will update our doc regarding the default value. Thanks |
regisss
pushed a commit
that referenced
this pull request
Nov 26, 2024
MohitIntel
pushed a commit
that referenced
this pull request
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before submitting