Skip to content

Fix for eos in eager mode #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regisss merged 3 commits into from
Sep 11, 2025
Merged

Fix for eos in eager mode #2197

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abbb487
Fix for eos in eager mode
12010486 Aug 8, 2025
be860f6
Merge branch 'huggingface:main' into fix_eager
12010486 Aug 26, 2025
c571332
Fix perf
12010486 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions optimum/habana/transformers/generation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2872,11 +2872,16 @@ def _sample(

if batch_size > 1 and has_eos_stopping_criteria:
eos_token_id = generation_config.eos_token_id
# Init eos_positions
eos_positions = torch.full((batch_size,), start_token_idx, dtype=torch.long, device=input_ids.device)
# Find the positions of the first eos_token_id in each sequence
eos_positions = (
torch.isin(input_ids[:, start_token_idx:], torch.tensor(eos_token_id)).int().argmax(dim=1)
+ start_token_idx
)
eos_positions_tmp = torch.isin(
input_ids[:, start_token_idx:], torch.tensor(eos_token_id).to(device=input_ids.device)
).int()
if eos_positions_tmp.numel() != 0:
# argmax(dim=1) is throwing this error in eager mode, if the tensor is empty
eos_positions = eos_positions + eos_positions_tmp.argmax(dim=1)

# Create a mask for positions greater than the first eos_token_id
mask = torch.arange(generation_config.max_length, device="hpu").expand(
batch_size, generation_config.max_length
Expand Down
Loading