Unify SetTrueOrFalseOrNone and StoreTrueFalseAction#2119
Merged
Conversation
ugolowic
approved these changes
Jul 8, 2025
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 8, 2025
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 8, 2025
astachowiczhabana
force-pushed
the
v1.19-release
branch
from
aa4ef29 to
5a982c1
Compare
astachowiczhabana
requested review from
libinta,
mandy-li and
vivekgoe
as code owners
astachowiczhabana
added a commit
that referenced
this pull request
Jul 8, 2025
astachowiczhabana
force-pushed
the
unify_args
branch
from
40758f2 to
72afaba
Compare
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 10, 2025
* Unify SetTrueOrFalseOrNone and StoreTrueFalseAction * Fix style
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 11, 2025
* Unify SetTrueOrFalseOrNone and StoreTrueFalseAction * Fix style
astachowiczhabana
added a commit
that referenced
this pull request
Aug 22, 2025
* Unify SetTrueOrFalseOrNone and StoreTrueFalseAction * Fix style
astachowiczhabana
added a commit
that referenced
this pull request
Aug 25, 2025
* Unify SetTrueOrFalseOrNone and StoreTrueFalseAction * Fix style
astachowiczhabana
added a commit
that referenced
this pull request
Sep 10, 2025
* Unify SetTrueOrFalseOrNone and StoreTrueFalseAction * Fix style
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
#371) * Unify SetTrueOrFalseOrNone and StoreTrueFalseAction * Fix style Co-authored-by: Adam Stachowicz <105052242+astachowiczhabana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the argument parsing logic in
examples/text-generation/run_generation.pyby replacing the customStoreTrueFalseActionclass with a newSetTrueOrFalseOrNoneaction. This change reduces complexity and improves maintainability.Argument Parsing Simplification:
StoreTrueFalseActionclass, which handled boolean and optional values for command-line arguments.StoreTrueFalseActionwithSetTrueOrFalseOrNonefor several arguments (--flash_attention,--flash_attention_recompute,--flash_attention_causal_mask) to streamline the handling of boolean flags.