Lm eval accuracy regression fix#2105
Merged
astachowiczhabana merged 2 commits intoJul 7, 2025
Merged
Conversation
astachowiczhabana
approved these changes
Jul 7, 2025
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 8, 2025
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 8, 2025
astachowiczhabana
added a commit
that referenced
this pull request
Jul 8, 2025
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 10, 2025
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 11, 2025
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
* Fix for accuracy regression * Fix for utf-8 encoding issue Co-authored-by: Silvia Colabrese <silvia.colabrese@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a small regression, ~-0.39% in some of the fp8 eval harness.
For example, if you execute:
and
with this fix we have an average accuracy of 66.683, while before we dropped to 66.422