Skip to content

Add support for setting --junitxml output via JUNITXML_DIR environment variable#2084

Merged
astachowiczhabana merged 1 commit into
huggingface:v1.19-releasefrom
HabanaAI:gplutop7_enalble_junitxml
Jul 4, 2025
Merged

Add support for setting --junitxml output via JUNITXML_DIR environment variable#2084
astachowiczhabana merged 1 commit into
huggingface:v1.19-releasefrom
HabanaAI:gplutop7_enalble_junitxml

Conversation

@gplutop7
Copy link
Copy Markdown
Collaborator

This PR adds support for automatically setting the --junitxml output path based on the environment variable JUNITXML_DIR if it is not explicitly provided via command-line options.

Behavior

  • If --junitxml is explicitly passed → no change in behavior.
  • If --junitxml is not provided but JUNITXML_DIR is set → the test result will be written to JUNITXML_DIR/result_.xml.
  • If neither is provided → no XML report is generated (default behavior remains unchanged).

Motivation
This change enables dynamic and automated control of test result locations in CI environments (e.g., Jenkins pipelines) without needing to explicitly pass --junitxml to pytest.

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss changed the base branch from v1.19-release to v1.18-release July 1, 2025 12:03
@regisss regisss changed the base branch from v1.18-release to v1.19-release July 1, 2025 12:03
@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Jul 1, 2025

Closing as #2094 was merged

@regisss regisss closed this Jul 1, 2025
@gplutop7
Copy link
Copy Markdown
Collaborator Author

gplutop7 commented Jul 2, 2025

Reopened to ensure the change is also applied to the v1.19-release branch.

@gplutop7 gplutop7 reopened this Jul 2, 2025
@astachowiczhabana astachowiczhabana merged commit fe74dae into huggingface:v1.19-release Jul 4, 2025
1 check passed
astachowiczhabana added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jul 8, 2025
astachowiczhabana added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jul 8, 2025
astachowiczhabana added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jul 10, 2025
astachowiczhabana added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jul 11, 2025
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Sep 8, 2025
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants