Remove bitsandbytes monkey-patching #2057
Merged
vivekgoe merged 2 commits intoJun 13, 2025
Merged
Conversation
Contributor
Author
|
@vivekgoe @regisss @astachowiczhabana Please review this change. |
vivekgoe
requested changes
Jun 13, 2025
Collaborator
vivekgoe
left a comment
vivekgoe
left a comment
There was a problem hiding this comment.
@ckvermaAI you also need to delete the actual functions defined in optimum-habana/optimum/habana/quantizers/bitsandbytes.py
astachowiczhabana
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a) We can get rid of all the bitsandbytes patching except _gaudi_validate_bnb_multi_backend_availability
b) Because of a lack of support from transformers for hpu (in get_available_devices function)
c) And in transformers-4.50.0, hpu is listed in get_available_devices function. And here we can get rid of the entire patching for bitsandbytes.