Skip to content

Add groups to slow_tests_image_to_text_example#2008

Merged
astachowiczhabana merged 3 commits into
huggingface:v1.19-releasefrom
HabanaAI:mirror2upstream_gplutop7_dev_gplutop7_add_groups_tests_image_to_text_example
Jul 3, 2025
Merged

Add groups to slow_tests_image_to_text_example#2008
astachowiczhabana merged 3 commits into
huggingface:v1.19-releasefrom
HabanaAI:mirror2upstream_gplutop7_dev_gplutop7_add_groups_tests_image_to_text_example

Conversation

@gplutop7
Copy link
Copy Markdown
Collaborator

No description provided.

@gplutop7 gplutop7 requested a review from regisss as a code owner May 28, 2025 13:20
@yafshar
Copy link
Copy Markdown
Contributor

yafshar commented May 28, 2025

@gplutop7 please remove the SW number from the title/

@gplutop7 gplutop7 changed the title [SW-228672] Add groups to slow_tests_image_to_text_example Add groups to slow_tests_image_to_text_example May 29, 2025
@malkomes
Copy link
Copy Markdown
Contributor

malkomes commented Jun 4, 2025

LGTM

@12010486 12010486 added run-test Run CI for PRs from external contributors and removed run-test Run CI for PRs from external contributors labels Jun 4, 2025
@12010486
Copy link
Copy Markdown
Contributor

12010486 commented Jun 4, 2025

Looks correct but it is impossible to run it on the proposed branch v1.19-release. If you want to refactor it to merge on main I can give it a try, or else let's wait for the branch to be better organized

@12010486
Copy link
Copy Markdown
Contributor

@gplutop7 could you solve the conflicts and ping me when done?

@astachowiczhabana astachowiczhabana force-pushed the mirror2upstream_gplutop7_dev_gplutop7_add_groups_tests_image_to_text_example branch from 14fe7cf to a4c4872 Compare June 11, 2025 20:54
…m_gplutop7_dev_gplutop7_add_groups_tests_image_to_text_example
@gplutop7
Copy link
Copy Markdown
Collaborator Author

Needs to be also cherrypicked to v1.18-release branch

@gplutop7
Copy link
Copy Markdown
Collaborator Author

@gplutop7 could you solve the conflicts and ping me when done?

@12010486 done

@12010486
Copy link
Copy Markdown
Contributor

LGTM! @regisss could you check and merge?

@regisss regisss changed the base branch from v1.19-release to v1.18-release July 1, 2025 12:02
@regisss regisss changed the base branch from v1.18-release to v1.19-release July 1, 2025 12:02
@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Jul 1, 2025

Closing as #2093 was merged

@regisss regisss closed this Jul 1, 2025
@gplutop7
Copy link
Copy Markdown
Collaborator Author

gplutop7 commented Jul 2, 2025

Reopened to ensure the change is also applied to the v1.19-release branch.

@gplutop7 gplutop7 reopened this Jul 2, 2025
@astachowiczhabana astachowiczhabana self-requested a review July 3, 2025 16:28
@astachowiczhabana astachowiczhabana merged commit cd481f9 into huggingface:v1.19-release Jul 3, 2025
1 check passed
astachowiczhabana added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jul 8, 2025
astachowiczhabana added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jul 8, 2025
astachowiczhabana added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jul 10, 2025
astachowiczhabana added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants