Tokenizer config fix for dynamic mode (#144)#1903
Merged
Merged
Conversation
Collaborator
|
@pramodkumar-habanalabs Can you share a code snippet that enables me to reproduce this issue with Llama 3.1 please? |
Collaborator
|
@regisss You can try with below |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
For the Llama2 7B Dynamic mode, with padding="max_length", the tokenizer produces 'input_ids' without padding and having actual tokens only in the list. This is expected and works fine.
For the Llama3.1 8B Dynamic mode, with padding="max_length", the tokenizer produces 'input_ids' with padding and having 128K tokens (which is the max model input length. This is not expected.
Fix: The tokenizer configuration has been changed to address this issue.